[MPlayer-dev-eng] [PATCH] Hack to allow compilation to go further

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Apr 24 17:39:17 CEST 2011


On Sun, Apr 24, 2011 at 05:19:44PM +0200, Ingo Brückl wrote:
> Reimar Döffinger wrote on Sun, 24 Apr 2011 11:45:54 +0200:
> 
> >> Another attempt.
> 
> > I think that's correct. If you have checked it actually works
> > (e.g. add a printf to ensure the code is executed, them provoke
> > it by running a video with too high -speed for it to keep up,
> > use -framedrop and -hardframedrop to enable the feature -
> > best use a video with B-frames for the first and a MPEG-2 for
> > the second option) it can be applied.
> 
> Did the tests.
> 
> With -speed 100, neither avctx->skip_frame nor avctx->skip_idct got changed.
> 
> With -speed 100 -framedrop, avctx->skip_frame got set.
> 
> With -speed 100 -hardframedrop, both avctx->skip_frame and avctx->skip_idct
> got set.
> 
> After a change of avctx->skip_frame or avctx->skip_idct they got reset to
> their initial values until the next change.
> 
> Seems to work. (Wow, my first non-gui patch.)

Great!

> BTW, can the configure patch be applied after that then?

You can and should remove the FF_API_HURRY_UP hack either at the same time
or directly after.
I'd like to leave the FF_API_MAX_STREAMS in there a bit longer since it doesn't
hurt and potentially eases regression testing.


More information about the MPlayer-dev-eng mailing list