[MPlayer-dev-eng] [PATCH 3/5] Prettify main MPlayer source file.

[Reimar Döffinger]

On Sun, Apr 17, 2011 at 06:35:21PM +0200, Clément Bœsch wrote:
> On Sat, Apr 16, 2011 at 03:41:33PM +0200, Reimar Döffinger wrote:
> > On Sat, Apr 16, 2011 at 12:02:51AM +0200, Clément Bœsch wrote:
> > > Direct use of uncrustify profile with mplayer.c
> > 
> > I thnk I mentioned it before: I'd really like to have a description
> > e.g. in DOCS/tech/svn-howto how to verify that the binary has not changed.
> > Maybe it can even be done with some helper-stuff in the Makefile.
> > Manually verifying or everyone having to figure it out themselves
> > just doesn't scale and just not doing it seems like a bad idea to me.
> 
> Indeed, I remember now, but can you give some precisions on what exactly
> you would like? Should we provide a way to test compilation and
> comparisons with all the possible CONFIG_? If so… how?

I don't think that will work out. Just an easy way for people to find
where something might have gone in a cosmetic change and/or in general
to verify a cosmetic change really is only that.

> Can you give an
> example of the helper usage you'd like? assert() can be avoided with
> -DNDEBUG, but how should we deal with the usage of __LINE__ for example?

That I have no idea for right now.