[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

[Nicolas George]

Le nonidi 29 ventôse, an CCXIX, Reimar Döffinger a écrit :
> libmpdemux/demuxer.h

Ok. Not very intuitive. And the API is quite treacherous: for example it
frees the original pointer if there is an overflow, but not if the realloc
fails.

> I don't understand what the fascination with those hard aborts are.
> It won't quite properly, it might leave behind gigantic core dumps
> causing issues due to the file system filling up, the terminal restoration
> code is there but I think it still uses non-signal safe functions and thus
> is not reliable at all, when encoding the file header won't be written thus
> possibly leaving behind a completely useless file even if it happens on
> e.g. the last black frame nobody cares about anyway.

I confess that since I disable core dumps by default and my shell restores
tty settings, I did not think of these issues.

> Yes, some of these do not apply here, and not failing promptly is ugly
> here since this is basically an encode-only feature, but still I just
> can't see how aborting would be a good idea ever (except that it might
> exploitable errors less likely or harder to exploit, but it doesn't seem
> that great for that either).

Well, I guess this is a matter of balance between the difficulty to catching
the error correctly and the problems caused by not doing so. And, this, in
turn, depends on how likely the error is.

Anyway, here is a new attempt at this, this time using exit_player.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Introduce-the-exit_player-function-in-mencoder.patch
Type: text/x-diff
Size: 1316 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110411/f84d26dd/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Introduce-mp_mem.-ch-for-memory-alloc-helpers.patch
Type: text/x-diff
Size: 4957 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110411/f84d26dd/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-vf_delogo-allow-to-change-the-rectangle-based-on-the.patch
Type: text/x-diff
Size: 7522 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110411/f84d26dd/attachment-0005.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110411/f84d26dd/attachment-0001.pgp>