[MPlayer-dev-eng] [PATCH] Support RGB framebuffer

[Alexander Stein]

On Thursday 07 April 2011, 23:26:31 Reimar Döffinger wrote:
> On Thu, Apr 07, 2011 at 05:56:22PM +0200, Alexander Stein wrote:
> > Am Mittwoch, 6. April 2011, 19:43:03 schrieb Reimar Döffinger:
> > > On Wed, Apr 06, 2011 at 08:42:11AM +0200, Alexander Stein wrote:
> > > > On Tuesday 05 April 2011, 18:31:03 Reimar Döffinger wrote:
> > > > > On Tue, Apr 05, 2011 at 05:52:52PM +0200, Alexander Stein wrote:
> > > > > > using this patch vo_fbdev uses the proper coloring on my RGB15
> > > > > > display used by a ARM AT91SAM9263. Otherwise I only get BGR
> > > > > > output. Best seen with a webcam showing my blue ethernet cable
> > > > > > which is displayed in orange.
> > > > > 
> > > > > This seems _hugely_ too complex, have you tested the patch I sent
> > > > > back then? (attached)
> > > > 
> > > > I tried your patch and it didn't work.
> > > 
> > > It detects your display as bgr, not rgb.
> > > What are the values for fb_vinfo.red.offset and fb_vinfo.blue.offset?
> > 
> > fb_vinfo.red.offset: 0
> > fb_vinfo.blue.offset: 10
> 
> Doesn't make any sense to me then.
> fb_rgb should be 1 then and thus I can't see any way
> it would accept a bgr format as your output shows.

I found the source of the problem: operator priority. In your patch you missed 
parenthesis around the ? operator. I attached a working patch based on your 
one.

Best regards,
Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rgb_fbdev2.diff
Type: text/x-patch
Size: 2947 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110411/4d9b08f2/attachment.bin>