[MPlayer-dev-eng] [RFC] all of FFmpeg as svn:external

[Reimar Döffinger]

On Thu, Sep 30, 2010 at 05:20:21PM +0200, Diego Biurrun wrote:
> On Thu, Sep 30, 2010 at 12:05:43PM +0300, İsmail Dönmez wrote:
> > 
> > On Tue, Sep 28, 2010 at 11:54 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > > > Updated version with some small fixes for make distclean...
> > >
> > > Applied.
> > 
> > This breaks mplayer build on OSX 64bit mode:
> > 
> > make -C ffmpeg/libavcodec
> > YASM	x86/deinterlace.o
> > x86/deinterlace.asm:79: error: macho: sorry, cannot apply 32 bit
> > absolute relocations in 64 bit mode, consider "[_symbol wrt rip]" for
> > mem access, "qword" and "dq _foo" for pointers.
> > x86/deinterlace.asm:81: error: macho: sorry, cannot apply 32 bit
> > absolute relocations in 64 bit mode, consider "[_symbol wrt rip]" for
> > mem access, "qword" and "dq _foo" for pointers.
> > 
> > Google tells me that yasm needs a DPIC flag on OSX and its in ffmpeg configure:
> > 
> > 2619:        enabled pic               && append YASMFLAGS "-DPIC"
> 
> This is what we have:
> 
>   test "$pic" = "yes"      && yasmdefines="$yasmdefines -DPIC"
> 
> So why did this suddenly break?

Because I'm stupid and did not add yasmdefines to YASMFLAGS.
Actually broke compilation on Windows as well, because -DPREFIX
was missing.
However I don't understand why we put these on the command-line
instead of into config.asm
Particularly in FFmpeg configure I don't understand it, it should
simplify the code there quite a bit.