[MPlayer-dev-eng] [PATCH] Two small subtitles improvments

[Reimar Döffinger]

On Thu, Sep 30, 2010 at 12:33:38AM +0200, Clément Bœsch wrote:
> Index: subreader.c
> ===================================================================
> --- subreader.c	(revision 32412)
> +++ subreader.c	(working copy)
> @@ -1130,13 +1129,8 @@
>  		{*uses_time=1;return SUB_VPLAYER;}
>  	if (sscanf (line, "%d:%d:%d ",     &i, &i, &i )==3)
>  		{*uses_time=1;return SUB_VPLAYER;}
> -	//TODO: just checking if first line of sub starts with "<" is WAY
> -	// too weak test for RT
> -	// Please someone who knows the format of RT... FIX IT!!!
> -	// It may conflict with other sub formats in the future (actually it doesn't)
> -	if ( *line == '<' )
> +	if (stristr (line, "<window"))
>  		{*uses_time=1;return SUB_RT;}
> -

Using stristr instead of just checking the start might
actually increase the risk of conflict, particularly considering future
HTML- or XML-based formats...
Also removing the empty line does not really belong here and don't
add a space after the function name for new code.