[MPlayer-dev-eng] configure is duplicating some CFLAGS

[Rowan James]

On 29/09/2010, at 9:18 PM, Rowan James wrote:

> I'm not yet sure how recent this is - I need to clean up a bit before I can bisect properly if needed; am desperately low on drive space ^_^
> 
> This was at least not produced when I submitted the patch for r31910, as clang would have been giving warnings for the ignored duplicate (as shown below) - there's a big chunk of $CFLAGS being duplicated in the CC args.
> 
> 
> On Darwin x86_64 w/ gcc 4.2.1 (Apple)
> 
> $configure && make
> 
> cc -MD -MP -O4 -march=core2 -mtune=core2 -pipe -ffast-math -fomit-frame-pointer -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99  -O4 -march=core2 -mtune=core2 -pipe -ffast-math -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -falign-loops=16 -shared-libgcc -mdynamic-no-pic -I. -Iffmpeg  -DPIC  -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include -c -o command.o command.c
> 
> where we see duplicated:
> -O4 -march=core2 -mtune=core2 -pipe -ffast-math -fomit-frame-pointer


Looks like a combination of $CFLAGS being added to $DEPFLAGS and both being added to the compiler command line.

Attached patch just removes $CFLAGS from $DEPFLAGS; but seems to produce the desired result:

$ configure && make

cc -MD -MP -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99  -O4 -march=core2 -mtune=core2 -pipe -ffast-math -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -falign-loops=16 -shared-libgcc -mdynamic-no-pic -I. -Iffmpeg  -DPIC  -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include -c -o command.o command.c


-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.patch
Type: application/octet-stream
Size: 411 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100929/29237feb/attachment.obj>
-------------- next part --------------