[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

[Reimar Döffinger]

On Tue, Sep 28, 2010 at 04:17:30PM -0700, Dirk Porezag wrote:
> Actually, removing the #ifdef  VO_XMGA in mga_template.c:set_window does not 
> help much here.

I never said so, I only said it can be removed (since it is pointless).

> However, in non GUI mode, WinID is always = -1 so check_resize isn't called at 
> all (except if a ConfigureNotify event is being processed, which happens only if 
> the window is really resized). I would really be grateful if someone could 
> explain to me why check_resize() is called ALWAYS whenever WinID > 0 (I refer to 
> line 821 in x11_common.c).

Because only one client can request ConfigureNotify events, and if WinID is > 0
someone else already may be using it, so in general we will not receive any.

> Nonetheless, the problem with vo_xmga flickering in GUI mode can also be fixed 
> by removing the vo_dwitdh and vo_dheight assignments in vo_xmga.c:set_window. 
> These assignments are not necessary since dwidth/dheight are managed nicely from 
> the non VO specfic parts of the code. Everything works and looks nicely without 
> these assignments (even with subtitles and in panscan mode).

There definitely has to be a difference in fullscreen + panscan mode, especially
if the video aspect is so that the borders are on the left and right.
Whether it's better or worse is a different question.