[MPlayer-dev-eng] [RFC] all of FFmpeg as svn:external

[Reimar Döffinger]

On Tue, Sep 28, 2010 at 05:41:41PM -0400, compn wrote:
> On Tue, 28 Sep 2010 22:54:57 +0200, Diego Biurrun wrote:
> >On Mon, Sep 27, 2010 at 10:14:46AM +0200, Diego Biurrun wrote:
> >> On Mon, Sep 27, 2010 at 09:57:15AM +0200, Diego Biurrun wrote:
> >> > On Sun, Sep 26, 2010 at 08:18:10PM +0200, Diego Biurrun wrote:
> >> > > On Sun, Sep 26, 2010 at 05:40:28PM +0200, Reimar Döffinger wrote:
> >> > > > On Sun, Sep 26, 2010 at 05:28:48PM +0200, Diego Biurrun wrote:
> >> > > > > On Sun, Sep 26, 2010 at 02:07:32PM +0200, Diego Biurrun wrote:
> >> > > > > > On Sun, Sep 26, 2010 at 10:56:12AM +0200, Reimar Döffinger wrote:
> >> > > > > > > 
> >> > > > > > > I'd _strongly_ prefer it if this wasn't all done in one go.
> >> > > > > > > In particular, I'd prefer if just moving to a full ffmpeg svn:external
> >> > > > > > > first, and then move to using FFmpeg configure only in a separate step.
> >> > > > > > 
> >> > > > > > OK, it should indeed be possible to separate these steps.
> >> > > > > > I'll get to it right now.
> >> > > > > 
> >> > > > > Here it is.  The diff is less than 10k, so it should actually be
> >> > > > > reviewable.
> >> > > > 
> >> > > > Does this work? Don't you need a config.h and config.mak in the ffmpeg
> >> > > > directory as well?
> >> > > 
> >> > > Hrmpf, thanks for saving me from embarassment.  You are right, it's not
> >> > > that easy.  I had config.mak still lying around from the other version.
> >> > > I'll figure something out...
> >> > 
> >> > OK, here is a working version, already with an enticing diffstat:
> >> > 
> >> >  Makefile   |   76 ++++++++++++++++++++--------------------
> >> >  common.mak |  114 -------------------------------------------------------------
> >> >  configure  |   32 ++++++++++-------
> >> >  subdir.mak |  101 ------------------------------------------------------
> >> >  4 files changed, 57 insertions(+), 266 deletions(-)
> >> > 
> >> > If there are no further comments I'd like to apply this soon.
> >> 
> >> Updated version with some small fixes for make distclean...
> >
> >Applied.
> 
> does 'make install' install both mplayer and
> ffmpeg/ffplay/ffprobe/ffserver?

It doesn't compile anything more than before, so those are not
even compiled.

> if not, can we do that?

I this would be surprising behaviour for most users and thus not a good idea.