[MPlayer-dev-eng] [PATCH] Capture feature

[Pásztor Szilárd]

Diego Biurrun:
> > > +    case M_PROPERTY_OK:
> > > +        set_osd_msg(OSD_MSG_SPEED, 1, osd_duration, MSGTR_OSDCapturing,
> > > +            mpctx->stream->capture_file ? MSGTR_Enabled :
> > > MSGTR_Disabled);
> 
> Indentation is still off.  If you break a line, you should not indent
> mechanically, but intelligently, i.e. optimized for readability.  For
> function calls this means that the next line should be aligned with
> the first function argument:
> 
>   set_osd_msg(OSD_MSG_SPEED, 1, osd_duration, MSGTR_OSDCapturing,
>               mpctx->stream->capture_file ? MSGTR_Enabled : MSGTR_Disabled);

Done.

> I still find this confusing and indirect, let me try to rephrase:
> 
>   .b \-capturefile <filename> (MPlayer only)
>   Allows capturing the primary stream (not additional audio tracks or
>   other kinds of streams) into the specified file upon pressing the
>   key bound to this function (see section INTERACTIVE CONTROL).
>   Same as for \-dumpstream, this will likely not produce usable
>   results for anything but MPEG streams.
>   Note that, due to cache latencies, there may be a delay between
>   the keypress and the moment capture begins/ends.
> 
> Is this still correct?

I don't completely agree with this because the last sentence means what you
asked and what is not the real situation. Upon keypress capturing of course
starts immediately, but what is read into the cache (if enabled) is what gets
written and that is somewhat ahead of what is displayed. This is what this
sentence should mean.
So I did a kind of merge of the two texts.

> Also, how does this differ from -dumpfile and -dumpstream apart from
> the interactivity?  I see a certain amount of duplication going on
> here.  We could have a -capture option and then set the filename to
> be captured to with -dumpfile as usual.  Am I missing something?

This is reasonable so I changed it to honor -dumpfile but i had to make that
non-static. The parameter is now -capture (docs are updated accordingly).

s.

          ------------------------------------------------------------
          |  Egoism is the drug that soothes the pain of stupidity.  |
          ------------------------------------------------------------
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mplayer-2010-09-28-capture.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100928/2174368b/attachment.asc>