[MPlayer-dev-eng] [PATCH] Capture feature

[Pásztor Szilárd]

Diego Biurrun:
> You don't use svn?

I can't because the server I use (195.70.57.4) is banned from 213.144.138.186
for some unknown reason.

> > +char *capture_dump_name = NULL;
> 
> Declare this closer to where it is actually used..

Done

> +    case M_PROPERTY_OK:
> +        set_osd_msg(OSD_MSG_SPEED, 1, osd_duration, MSGTR_OSDCapturing,
> +            mpctx->stream->capture_file ? MSGTR_Enabled : MSGTR_Disabled);
>
> Indentation is off.

No because it is a continuation of the previous line.

> > --- mplayer-export-2010-09-13/DOCS/man/en/mplayer.1	2010-09-08 07:29:05.000000000 +0200
> > +++ mplayer-export-2010-09-13-capture/DOCS/man/en/mplayer.1	2010-09-13 19:08:09.000000000 +0200
> >
> > +Note that, due to cache latencies, captured data may start and stop
> > +somewhat delayed compared to what you see displayed.
> >
> You mean that there is a delay between the keypress and MPlayer's reaction
> to the keypress?

No, the stream position is not exactly what is displayed because of caching.
I changed the text a little.

> > +extern char *capture_dump_name;
>
> This belongs in command.h.

Done
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-2010-09-28-capture.diff
Type: application/octet-stream
Size: 13407 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100928/b84165c8/attachment.obj>