[MPlayer-dev-eng] [RFC] all of FFmpeg as svn:external

Diego Biurrun diego at biurrun.de
Mon Sep 27 10:14:46 CEST 2010


On Mon, Sep 27, 2010 at 09:57:15AM +0200, Diego Biurrun wrote:
> On Sun, Sep 26, 2010 at 08:18:10PM +0200, Diego Biurrun wrote:
> > On Sun, Sep 26, 2010 at 05:40:28PM +0200, Reimar Döffinger wrote:
> > > On Sun, Sep 26, 2010 at 05:28:48PM +0200, Diego Biurrun wrote:
> > > > On Sun, Sep 26, 2010 at 02:07:32PM +0200, Diego Biurrun wrote:
> > > > > On Sun, Sep 26, 2010 at 10:56:12AM +0200, Reimar Döffinger wrote:
> > > > > > On Sun, Sep 26, 2010 at 02:30:58AM +0200, Diego Biurrun wrote:
> > > > > > > 
> > > > > > > All sorts of comments very welcome.
> > > > > > 
> > > > > > I'd _strongly_ prefer it if this wasn't all done in one go.
> > > > > > In particular, I'd prefer if just moving to a full ffmpeg svn:external
> > > > > > first, and then move to using FFmpeg configure only in a separate step.
> > > > > 
> > > > > OK, it should indeed be possible to separate these steps.
> > > > > I'll get to it right now.
> > > > 
> > > > Here it is.  The diff is less than 10k, so it should actually be
> > > > reviewable.
> > > 
> > > Does this work? Don't you need a config.h and config.mak in the ffmpeg
> > > directory as well?
> > 
> > Hrmpf, thanks for saving me from embarassment.  You are right, it's not
> > that easy.  I had config.mak still lying around from the other version.
> > I'll figure something out...
> 
> OK, here is a working version, already with an enticing diffstat:
> 
>  Makefile   |   76 ++++++++++++++++++++--------------------
>  common.mak |  114 -------------------------------------------------------------
>  configure  |   32 ++++++++++-------
>  subdir.mak |  101 ------------------------------------------------------
>  4 files changed, 57 insertions(+), 266 deletions(-)
> 
> If there are no further comments I'd like to apply this soon.

Updated version with some small fixes for make distclean...

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: external_ffmpeg_v5.diff
Type: text/x-diff
Size: 10254 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100927/41f1323c/attachment.diff>


More information about the MPlayer-dev-eng mailing list