[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

[Reimar Döffinger]

On Sun, Sep 26, 2010 at 01:52:21PM -0700, Dirk Porezag wrote:
> I assume that the handling in mga_template.c:set_window() is incorrect but 
> before I do something stupid please answer me the following questions: 
> 
> 1. What's the exact meaning of vo_dwidth/vo_dheight and 
> vo_screenwidth/vo_screenheight? Size of the window available to mplayer (e.g. 
> real fullscreen in fullscreen mode) or the size of the movie on screen 
> (excluding potential "blacked out" areas)? 
> 
> 2. What should these values be in fullscreen mode?

In the past they had wildly varying meaning, but nowadays they are supposed
to be the size of the full window.
Which btw. should mean you can just get rid of the whole
#ifdef VO_XMGA in set_window.
If you just remove the modification of these values in set_window things
should mostly work.
Only the subtitle drawing code I guess might be off, but I am not sure...
it actually looks like that one might behave more correctly after that as
well (you'll need to use -panscan to see the difference, but that code
is broken anyway since it only handles the width differently for panscan,
so if the screen has a larger aspect than the video it won't work right...)