[MPlayer-dev-eng] [PATCH] Automatic downmix

[Tobias Diedrich]

Nicolas George wrote:
> Le quintidi 5 vendémiaire, an CCXIX, Clément Bœsch a écrit :
> > Well, they don't seem that stupid in fact (at least for the non-dolby
> > ones). You can test it yourself, I attached an updated patch.
> 
> It's not that they are stupid, just they are not inherently better. And in
> the absence of an aesthical difference, I think readability and simplicity
> should be favored.

They are better because they are consistent.

If you'd like to use less digits for better readability I'd argue
that probably 2 significant digits would suffice.
But for only one digit I think the error is a bit too big.
For example in the 8 channel case (which is the worst case here,
because the values are between .227 and .160) you get a 25% error by
rounding 0.160 up to 0.2, whereas the 2% error from rounding .227 to
.23 is neglegible.

Still, I don't think that using less digits for constants improves
readability.

-- 
Tobias						PGP: http://8ef7ddba.uguu.de