[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

[Reimar Döffinger]

On Sun, Sep 26, 2010 at 05:18:10AM -0700, Dirk Porezag wrote:
> Reimar, I completely understand your problem with people like me who are trying 
> to fix issues in code they don't completely understand, for this reason I'm 
> grateful for your explanations.

Sorry, I didn't mean it like that. I just wanted to make real clear
what the problem is.
You're new to the code and I know there's a lot of implicit/undocumented
knowledge you just can't have.

> As for your question: with "-fs" the current version doesn't even initialize in 
> fullscreen mode with vo_xmga. But is also doesn't with vo_x11 or vo_xv! At least 
> for me. Can you confirm this? The SVN version as of 2010-05-16 had it working 
> for vo_xv and vo_xmga but not for vo_x11.

Hm, are you testing command-line mplayer or only gmplayer? The Gui isn't
really supported, though I'll take a little bit of time to fix things if
I feel like it.

> At first sight, vo_dwidth etc. is initialized in libvo/vo_xmga.c:config(), also 
> I'd expect that the first call to libvo/x11_common.c:vo_x11_update_geometry() 
> should take care of setting these variables if they are not initialized 
> directly. Looks like this needs some further digging.

Probably yes, the issue is likely to be somewhere around there.
I'm really happy to help, but you would still have to do the biggest part of the
work since I don't have the hardware.