[MPlayer-dev-eng] [PATCH] Automatic downmix

[Clément Bœsch]

On Sun, Sep 26, 2010 at 10:21:28AM +0200, Nicolas George wrote:
> Le quartidi 4 vendémiaire, an CCXIX, Clément Bœsch a écrit :
> > Well, if I understand it well, I don't have to change something; new
> > version attached.
> 
> The code seems quite simple, and all tests I could think of behaved
> satisfactorily. Just a small point:
> 
> > +        return af_append(s, s->first, af_pan_str);
> > +    return NULL;
> 
> > +      af_downmix(s);
> 
> Is there a reason to return a value and then just ignore it instead of
> returning nothing at all?
> 

It's "historical"; there was a time where I needed to check the return
value in order to reinit or not the chain list. As I said in a previous
mail, I can remove it but I'm not sure it's harmless to keep it (if it
needs to be checked later).

-- 
Clément B.