[MPlayer-dev-eng] [PATCH] Automatic downmix

[Reimar Döffinger]

On Sat, Sep 25, 2010 at 02:25:13PM +0200, Clément Bœsch wrote:
> On Sat, Sep 25, 2010 at 01:56:57PM +0200, Reimar Döffinger wrote:
> > On Sat, Sep 25, 2010 at 01:37:53PM +0200, Clément Bœsch wrote:
> > > @@ -438,6 +457,9 @@
> > >  
> > >    // Check if this is the first call
> > >    if(!s->first){
> > > +    // Append a downmix pan filter at the beginning of the chain if needed
> > > +    if (s->input.nch != audio_output_channels && audio_output_channels == 2)
> > > +      af_downmix(s);
> > >      // Add all filters in the list (if there are any)
> > >      if(!s->cfg.list){      // To make automatic format conversion work
> > >        if(!af_append(s,s->first,"dummy"))
> > 
> > I think this should now be
> > if (!s->first && !af_append...
> > the dummy filter should only be inserted if there's no other filters.
> > I changed the code in SVN a bit so you won't have to change this.
> 
> Well, if I understand it well, I don't have to change something; new
> version attached.

Looks fine to me, Nicolas would you have a look too and apply if it seems
ok to you as well?