[MPlayer-dev-eng] [PATCH] Automatic downmix

[Clément Bœsch]

On Fri, Sep 24, 2010 at 06:33:39PM +0200, Nicolas George wrote:
> Le duodi 2 vendémiaire, an CCXIX, Clément Bœsch a écrit :
> > In fact, the prepend version issues a problem: since the pan2 downmix is
> > placed before the pan6 filter, in the second run, it still observes a 6
> > channels output at the end of the chain, and then adds again the downmix
> > filter.
> 
> Like Reimer, I believe you should test the number of channels at the start
> of the chain, just after the codec.
> 

I fixed that in the last version of the patch Reimer has commented.

> > So I introduce a first_run variable in order to avoid that. Then, here are
> > the new results I observed with the attached patch.
> 
> With such a flag, what happens if there are sevral files, some of which
> requiring auxiliary downmix but not all, possibly alternating?
> 

It's not a "static" flag so I suppose it's fine; but how do you manage to
do what you are talking about with mplayer (just in case, in order to
test)?

> (I'm sorry if I seem to be nagging you with always more requirements, that
> is not intentional. I guess we all discover as we go along that the problem
> you endeavored to solve has a lot of subtle pitfalls.)
> 

No no, I'm fine with it, I understand :)

> Regards,
> 
> -- 
>   Nicolas George

Regards,

-- 
Clément B.