[MPlayer-dev-eng] [PATCH] Automatic downmix

[Nicolas George]

Le duodi 2 vendémiaire, an CCXIX, Clément Bœsch a écrit :
> Normal downmix case (Flac 5.1, no options):
> 
>   Before downmix, filter list is:
>     [dummy]
>   After downmix + reinit, filter list is:
>     [format] → [pan] → [dummy]
> 
> And with -channels 2 -af pan=6:...:
> 
>    Before downmix, filter list is:
>      [format] → [pan (upmix 6 chan)]
>    After downmix + reinit, filter list is:
>      [format] → [pan (downmix 2 chan)] → [pan (upmix 6 chan)]
> 
> Is this what you would like? Or as I said, forced before the format filter?

That looks right. Unless I am mistaken, the format filter is automatically
added and necessary because the codec outputs shorts and pan only accepts
floats¹.

Could you just do two more checks please:

- The above cases with a codec that handles downmixing natively, AC3 for
  example. I expect to see something like that:

  Normal case: [dummy]

  -channels 2 -af pan=6: [format] -> [pan 6] -> [dummy]

- The above cases with a AO driver that does not handle float, oss for
  example. I expect something like that:

  [format] -> [pan] -> [format]
  [format] -> [pan 2] -> [pan 6] -> [format]

  (not sure where the dummy would get exactly)

If this works satisfactorily, I think I can take on me to apply it at last.
Is this the version in your mail dated "Thu, 16 Sep 2010 21:31:39 +0200"?

Regards,

-- 
  Nicolas George


1: An integer version of basic filters like pan may be nice, but that is
another story.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100923/cf1dd88b/attachment.pgp>