[MPlayer-dev-eng] [PATCH] print interlacing info on decode

[Jarek Czekalski]

  Thanks for having a look at this. I've corrected my errors. Please see 
some comments below.

W dniu 09/16/2010 10:31 AM, Diego Biurrun pisze:
>
>> --- libmpcodecs/dec_video.h	(revision 32249)
>> +++ libmpcodecs/dec_video.h	(working copy)
>> @@ -22,6 +22,7 @@
>>   #include "libmpdemux/stheader.h"
>>
>>   extern int field_dominance;
>> +extern int print_info_on_next_decode;
> This is not the right place for this extern declaration -
> the variable is not declared in dec_video.c.
You're probably wrong. Both variables are declared in the same "c", and 
called "extern" in the same "h" (dec_video.*).
>> --- mplayer.c	(revision 32249)
>> +++ mplayer.c	(working copy)
>> @@ -3815,6 +3815,7 @@
>>   if(mpctx->loop_times==1) mpctx->loop_times = -1;
>>
>>   mp_msg(MSGT_CPLAYER,MSGL_INFO,MSGTR_StartPlaying);
>> +print_info_on_next_decode = 1;
>>
>> --- mencoder.c	(revision 32249)
>> +++ mencoder.c	(working copy)
>> @@ -686,6 +686,7 @@
>>     m_config_push(mconfig);
>>     m_entry_set_options(mconfig,&filelist[curfile]);
>>     filename = filelist[curfile].name;
>> +  print_info_on_next_decode = 1;
> At a glance these look like pretty random places.
Don't know how to change this. All the places that fulfill following 2 
conditions are good for my target:
1. belong to a loop repeated for every file
2. precede calls to decode_video
The rest is a matter of taste, I can fit yours :).
Maybe I'll try to explain my ideas:
a) mplayer: I put this right after the mp_msg "Starting playback..."
b) mencoder: It has no "Starting playback", so I used the label 
"play_next_file" and positioned assignment at the end of the first block 
after this label

Regards
Jarek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: info_decode_20100916.diff
Type: text/x-patch
Size: 2759 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100916/cefad4f4/attachment.bin>