[MPlayer-dev-eng] [PATCH] merge all FFmpeg configure checks
diego at biurrun.de
Mon Sep 13 20:20:50 CEST 2010
On Mon, Sep 13, 2010 at 07:55:10PM +0200, Reimar Döffinger wrote:
> On Mon, Sep 13, 2010 at 07:27:12PM +0200, Diego Biurrun wrote:
> > On Mon, Sep 13, 2010 at 07:19:45PM +0200, Diego Biurrun wrote:
> > > On Sun, Sep 12, 2010 at 06:18:37PM +0200, Reimar Döffinger wrote:
> > > > On Sun, Sep 12, 2010 at 05:59:18PM +0200, Diego Biurrun wrote:
> > > > > I'd like to commit $attached unless I have overlooked something
> > > > > important. It merges all the separate FFmpeg library checks into
> > > > > one. I'm assuming that checking for libavcore assures us that the
> > > > > FFmpeg version is new enough. The diffstat is quite convincing:
> > > >
> > > > Well, libavutil is a bit of an issue there.
> > > > Let us ignore the included libavutil for a moment since 'we' (not
> > > > me so much, but...) want to get rid of it at some point.
> > > > Thing is, we need libavutil to compile no matter what.
> > > > If there is only a single check for FFmpeg, that would then
> > > > mean we always need FFmpeg.
> > > > So I think either the libavutil check still needs to be
> > > > separate or we could just as well get rid of the whole
> > > > FFmpeg conditionals...
> > >
> > > Here is a new patch that takes this into account. Better?
> Maybe I miss something, but I don't see any difference in
> libavutil handling in that one?
Now configure will always error out if the libavutil directory
is not present. The diff is rather large and unreadable...
> But apply whatever you want, I just wanted to make sure you
> consider that case, I think you can at least as well as I
> decide how to handle that best.
For larger sets of changes a second pair of eyes is always helpful.
More information about the MPlayer-dev-eng