[MPlayer-dev-eng] [PATCH] add OpenAL backend device support

Erik Hofman erik at ehofman.com
Mon Sep 13 18:54:10 CEST 2010


On Mon, 2010-09-13 at 18:41 +0200, Reimar Döffinger wrote:
> On Mon, Sep 13, 2010 at 05:25:04PM +0200, Erik Hofman wrote:
> > On Mon, 2010-09-13 at 17:02 +0200, Diego Biurrun wrote:
> > 
> > > Please respect the coding style of the rest of the file and format
> > > your function headers accordingly.
> > 
> > I'm willing to changes the things you pointed out but only if you think
> > it's a useful patch in the first place.
> 
> In principle yes, but having > 10% of code for this feature is quite
> ridiculous.
> I'm quite sure it's possible to get it to a reasonable size, but
> if you want quick results just getting rid of the device list printing
> is probably simplest.

It's your call, I thought it might be useful to be able to print the
device list, but I agree that the way OpenAL provides the list is a bit
long-winded.

I'll see if I can get up with something simpler and send a new patch due
time.

Erik



More information about the MPlayer-dev-eng mailing list