[MPlayer-dev-eng] [PATCH] de-templatize TV new_handle function

Diego Biurrun diego at biurrun.de
Mon Sep 13 18:50:53 CEST 2010


On Mon, Sep 13, 2010 at 06:36:11PM +0200, Reimar Döffinger wrote:
> On Mon, Sep 13, 2010 at 04:58:36PM +0200, Diego Biurrun wrote:
> > On Sun, Sep 12, 2010 at 04:06:04PM +0200, Reimar Döffinger wrote:
> > > On Sun, Sep 12, 2010 at 01:52:03PM +0200, Diego Biurrun wrote:
> > > > +tvi_handle_t *tv_new_handle(const size_t size,
> > > 
> > > What's that const supposed to be good for?
> > 
> > The function parameter is not changed so I figured it would not hurt..
> 
> It also doesn't have any advantage, and it does hurt in so far that
> it makes changing the function more annoying (e.g. if you wanted to enforce
> a minimum "size" you'd either have to add another variable or remove that
> const).

New patch without const.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tv_handle2.diff
Type: text/x-diff
Size: 4021 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100913/98c9fce5/attachment.diff>


More information about the MPlayer-dev-eng mailing list