[MPlayer-dev-eng] [PATCH] add OpenAL backend device support

[Diego Biurrun]

On Mon, Sep 13, 2010 at 12:08:47PM +0200, Erik Hofman wrote:
> 
> For my own purpose I needed to specify a different OpenAL device instead
> of the default one. This patch add support for the device="" parameter
> for the openal backend  as well as adding support for the help
> parameter, showing a list of available devices.
> 
> --- libao2/ao_openal.c	(revision 32219)
> +++ libao2/ao_openal.c	(working copy)
> @@ -62,7 +62,9 @@
>  static int unqueue_buf[MAX_CHANS];
>  static int16_t *tmpbuf;
>  
> +static void printList(const char *header, char separator, const char eol, const char *extensions);

Avoid this ugly forward declaration by placing the functions in
the appropriate order.

> @@ -252,3 +280,71 @@
> +
> +static void
> +printChar (int c, int *width)
> +{

Please respect the coding style of the rest of the file and format
your function headers accordingly.

> +  while (1)
> +  {
> +    if (extensions[end] == separator || extensions[end] == '\0')
> +    {
> +      if (width + end - start + 2 > maxmimumWidth)
> +      {
> +         printChar ('\n', &width);
> +         indent (&width);
> +      }
> +      while (start < end)
> +      {
> +         printChar (extensions[start], &width);
> +         start++;
> +      }
> +      if (extensions[end] == '\0')
> +      {

same here; inconsistent { placement

Diego