[MPlayer-dev-eng] [PATCH] Automatic downmix

[Nicolas George]

Le septidi 27 fructidor, an CCXVIII, Clément Bœsch a écrit :
> Mmh. The pan filter simply does not apply in this case, and there is this
> message:
> 
>   [AO SDL] Samplerate: 44100Hz Channels: Stereo Format floatle
>   [AO SDL] Unsupported audio format: 0x1d.

I am not sure what you mean here, but if the change prevents the audio from
playing with SDL, I think a lot of people would be entitled to complain.

> +        [3] = "pan=2:" /*FL*/"0.6:0:" /*FR*/"0:0.6:"                                  /*FC*/"0.4:0.4",
> +        [4] = "pan=2:" /*FL*/"0.6:0:" /*FR*/"0:0.6:" /*BL*/ "0.4:0:"  /*BR*/"0:0.4",

I think something like this would probably be a little more readable:

+        /*               FL       FR       RL       RR       FC       LF */
+        [3] = "pan=2:" "0.6:0:" "0:0.6:"                  "0.4:0.4",
+        [4] = "pan=2:" "0.6:0:" "0:0.6:" "0.4:0:" "0:0.4",

with a single line of comments as column titles.


> +    // Append a downmix pan filter to the end of the chain if needed
> +    af_downmix(s);
> +

I still think the place is not right. I mean: you are tinkering with the
number of channels. I see just a few lines earlier something that adds a
"channels" filter. It looks really redundant to me.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100913/d78c74e8/attachment.pgp>