[MPlayer-dev-eng] [PATCH] Dynamic list of EOSD sources

[Reimar Döffinger]

On Sun, Sep 12, 2010 at 11:59:46AM +0200, Nicolas George wrote:
> Le sextidi 26 fructidor, an CCXVIII, Reimar Döffinger a écrit :
> > Please do not use "unsigned" type unless you have a very good reason to.
> > It makes it harder to extend the API e.g. by giving negative
> > values a meaning (and actually for the border I think negative values
> > are already used for panscan-zoom, so I suspect these changes may
> > actually break things).
> 
> Changed, except for the "changed" field, which IMHO is more likely to evolve
> in a bitfield.

Works just fine with int, too. And FFmpeg uses int for that too (see
e.g. the buffet_hints in avcodec.h).

> I usually use unsigned whenever possible since they are easier for the
> compiler to optimize.

Why do you think that? PPC64 e.g. has a lot more issues with unsigned
than with int. Also since overflow is undefined for signed, the compiler
can do more optimizations.

> > Never heard the ter RGBT used. If it is the same, use RGBA, if not
> > explain the difference.
> 
> T is the complement of A (alpha).

Haven't looked if you did, but just make sure that is documented, then
it's no problem.