[MPlayer-dev-eng] [PATCH] Dynamic list of EOSD sources
Reimar.Doeffinger at gmx.de
Sun Sep 12 11:36:11 CEST 2010
On Sun, Sep 12, 2010 at 11:23:42AM +0200, Nicolas George wrote:
> + unsigned changed = 0;
> + unsigned w, h; ///< screen dimensions, including black borders
> + unsigned srcw, srch; ///< unscaled source dimensions
> + unsigned mt, mb, ml, mr; ///< borders (top, bottom, left, right)
> + unsigned unscaled; ///< EOSD objects are rendered at native resolution
> + unsigned changed; ///< settings have changed since last update
> + unsigned w, h; //< Bitmap width, height
Please do not use "unsigned" type unless you have a very good reason to.
It makes it harder to extend the API e.g. by giving negative
values a meaning (and actually for the border I think negative values
are already used for panscan-zoom, so I suspect these changes may
actually break things).
> + uint32_t color; //< Bitmap color and transparency, RGBT
Never heard the ter RGBT used. If it is the same, use RGBA, if not
explain the difference.
More information about the MPlayer-dev-eng