[MPlayer-dev-eng] [PATCH] Automatic downmix

[Nicolas George]

Le quintidi 25 fructidor, an CCXVIII, Reimar Döffinger a écrit :
> Please test this very carefully, especially make sure that
> all kinds of mono/stereo files still work with -channels 6.
> I am for some reason quite convinced this was 0 for a good reason.

You were right advising more care: with -channels 6, this version inits the
AO at 6 channels even for stereo files. It still works, but it is not
correct (for example, with my setup, the stereo does not get sent to the
rear speakers as it should).

Furthermore, when the downmix is in effect, fixup_output_format adds a
completely unnecessary "channels" filter at the end of the chain, since the
"pan" filter is added only afterwards.

The more I look at it, the more I think my first impulse was right: Clément,
I believe you should move the call to downmix_if_needed to place it before
the initialization of the audio output.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100911/da0be26d/attachment.pgp>