[MPlayer-dev-eng] [PATCH] Fix "initialization discards qualifiers" warnings in cfg-*.h

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Sep 9 22:34:39 CEST 2010


On Thu, Sep 09, 2010 at 01:49:46PM +0200, ubitux wrote:
> On Thu, Sep 09, 2010 at 07:19:49AM +0200, Reimar Döffinger wrote:
> > On Wed, Sep 08, 2010 at 11:01:06PM +0200, ubitux wrote:
> > > The void *p pointer initialization in the m_option array have mixed
> > > initialization (sometimes with the '&' unary operator, sometimes not). The
> > > patch also makes this consistent.
> > 
> > It's not inconsistent, we don't use & to get the address of an array type,
> > only for the other types.
> 
> Oh well ok… may I ask why?

Less unnecessary clutter. So mostly no real reason beyond personal taste.
Anyway, if readability is a concern, some alignment pretty-printing would
probably help far more than this minor detail.


More information about the MPlayer-dev-eng mailing list