[MPlayer-dev-eng] [PATCH] Capture feature

[Diego Biurrun]

On Thu, Sep 09, 2010 at 01:08:36PM +0200, Pásztor Szilárd wrote:
> Reimar Döffinger:
> > Uh, about 1/3 the amount of code, plus it actually supports more actions
> > and it will profit from extensions/fixes to the generic flag handling code.
> > But call it "more maintainable" if that does not fit your definition of
> >"complex".
> 
> Attached with the additional manpage entry.

Lose the tabs.

> --- mplayer-export-2010-09-09/command.c	2010-09-04 01:49:35.000000000 +0200
> +++ mplayer-export-2010-09-09-capture/command.c	2010-09-09 12:40:21.700249775 +0200
> @@ -71,6 +71,7 @@
>  #define ROUND(x) ((int)((x)<0 ? (x)-0.5 : (x)+0.5))
>  
>  extern int use_menu;
> +char *capture_dump_name=NULL;

Please respect the surrounding coding style and put spaces around the =.

> @@ -1110,6 +1111,68 @@ static int mp_property_deinterlace(m_opt
>  
> +static int mp_property_capture(m_option_t *prop, int action,
> +                                   void *arg, MPContext *mpctx)

Indentation is off.

> --- mplayer-export-2010-09-09/DOCS/man/en/mplayer.1	2010-09-08 07:29:05.000000000 +0200
> +++ mplayer-export-2010-09-09-capture/DOCS/man/en/mplayer.1	2010-09-09 13:00:56.751499206 +0200
> @@ -1340,6 +1342,16 @@ from the current position, MPlayer will 
>  .
>  .TP
> +.B \-capturefile <filename> (MPlayer only)
> +Allows capturing the primary stream (e.g. not additional audio or others)
> +into the specified file. If this option is given, capturing can be started
> +and stopped by pressing the key bound to this function (see section
> +INTERACTIVE CONTROL). The capture file produced by this function is the same
> +as that of -dumpstream and will probably be useless for anything else than
> +MPEG streams. Note that, due to cache latencies, captured data may start
> +and stop somewhat delayed compared to what you see displayed.

New sentences on new lines in the man page please.

Diego