[MPlayer-dev-eng] [PATCH] Automatic downmix

[Nicolas George]

Le septidi 27 thermidor, an CCXVIII, ubitux a écrit :
> +static void downmix_if_needed()

I think MPlayer coding style requires "(void)".

> +        af_add(mpctx->mixer.afilter, "pan=2:"
> +                                     "0.4:0:"      // Front left
> +                                     "0:0.4:"      // Front right
> +                                     "0.15:0:"     // Back left
> +                                     "0:0.15:"     // Back right
> +                                     "0.25:0.25:"  // Center
> +                                     "0.1:0.1:"    // LFE
> +                                     "0.1:0:"      // Auxiliary left
> +                                     "0:0.1"       // Auxiliary right
> +        );

The indentation is unusual, but it looks nice. I believe it's ok.

>      mpctx->mixer.volstep = volstep;
> +
> +    downmix_if_needed();

Is the extra empty line really necessary?


Le duodi 22 fructidor, an CCXVIII, Diego Biurrun a écrit :
> Two committers have been discussing this patch with you.
> Guys, get a move on and either commit or reject the patch please.

I believe one of them is me, although I was not committer at the time I
actually discussed the patch, I believe.

There is still a problem with this patch: the audio output gets initialized
for the original number of channels, not the reduced stereo. Example:

$ ./mplayer -channels 2 -v /tmp/6_Channel_ID.ac3 |& grep 'alsa.*device'
alsa-init: using device default
$ ./mplayer -channels 2 -v /tmp/6_Channel_ID.wav |& grep 'alsa.*device'
alsa-init: device set to surround51
alsa-init: using device surround51

(First call: AC3, built-in downmix, second call: WAVE, new generic downmix.)

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100908/b0e35192/attachment.pgp>