[MPlayer-dev-eng] [PATCH] fix to vdpau
Reimar.Doeffinger at gmx.de
Tue Sep 7 21:25:57 CEST 2010
On Tue, Sep 07, 2010 at 07:27:24PM +0200, Dan Oscarsson wrote:
> tis 2010-08-03 klockan 10:09 +0200 skrev Dan Oscarsson:
> > sön 2010-08-01 klockan 19:45 +0200 skrev Reimar Döffinger:
> > > On Sun, Aug 01, 2010 at 07:29:42PM +0200, Dan Oscarsson wrote:
> > > > Attached is a small fix to vo_vdpau.c as otherwise it will set deint_mpi
> > > > to NULL outside its size. This has existed for a long time so it does
> > > > not crash mplayer normally.
> > > >
> > >
> > > This code is duplicated from free_video_specific which does it right.
> > > Even if you don't want to merge them, at least copy it 1:1.
> > I guess the original coder wanted to merge the two loops.
> > The attached patch follows the code in free_video_specific.
> I have not seen any comments on my latest version that I attached now
> long ago. Nor is it applied.
> Is it ok Reimar?
I have no objections (except that the continuing code duplication still remains
a maintainance issue in my view), but I think Carl is using it more than I am
and I consider him to be maintaining that code.
Carl, if you agree with that, how about adding yourself to DOCS/tech/MAINTAINERS?
(you can of course still ask me to review VDPAU patches :-) )
More information about the MPlayer-dev-eng