[MPlayer-dev-eng] [PATCH] Capture feature

[Reimar Döffinger]

On Mon, Sep 06, 2010 at 07:11:01PM +0200, Pásztor Szilárd wrote:
> Reimar Döffinger:
> > For example it prints "enabled" when you set from enabled to enabled but
> > not when it is set from "disabled" to "disabled".
> 
> Do you prefer printing the existing state (disabled or enabled) when the
> value is set but not changed, or not printing anything in this case?

I think not printing is better, however if one results in simpler code
use that.

> > I think something like below should be close to working and much less complex
> > (and also support M_PROPERTY_PRINT)
> 
> I'm having a hard time convincing myself that your solution is less complex
> but maybe a little rethinking can simplify things

Uh, about 1/3 the amount of code, plus it actually supports more actions
and it will profit from extensions/fixes to the generic flag handling code.
But call it "more maintainable" if that does not fit your definition of "complex".