[MPlayer-dev-eng] [PATCH] Capture feature
diego at biurrun.de
Mon Sep 6 13:00:52 CEST 2010
On Sun, Sep 05, 2010 at 06:06:56PM +0200, Reimar Döffinger wrote:
> On Sun, Sep 05, 2010 at 02:01:34PM +0200, Pásztor Szilárd wrote:
> > Reimar Döffinger:
> > > Sorry that I was unclear. I didn't mean for you to implement
> > > this feature, I was just explaining why it is better to have it in the stream struct.
> > > This approach ends up with more global variables, I was rather
> > > hoping to keep the stream layer clean from that.
> > > I don't know if/how this is possible, but my idea was for the
> > > command.c code to open/close the file and set the FILE *
> > > within the stream appropriately, and not having any logic
> > > beyond if (capture_file) fwrite(...);
> > > in the stream layer...
> > Here I attach a simpler version where only the primary stream
> > gets dumped again (it doesn't make much sense to make things
> > more complicated than that). No bumming global variables and
> > no extensive logic in the stream beyond writing.
> Please send patches with some more appropriate mime type, e.g.
> text/plain, this makes reviewing and answering much simpler.
I have the following in my .muttrc:
macro index,pager,attach \cV "<edit-type>^Utext/x-diff\n" "Fix diff mime type"
More information about the MPlayer-dev-eng