[MPlayer-dev-eng] [RFC] rgb2rgb global function pointers

[Ramiro Polla]

On Tue, Aug 31, 2010 at 9:13 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, Aug 27, 2010 at 12:06:34PM -0300, Ramiro Polla wrote:
>>
>> These are the places that are still using those functions directly:
>> ./gui/wm/ws.c:314:     wsConvFunc=rgb32tobgr32;
>> ./gui/wm/ws.c:322:     wsConvFunc=rgb32tobgr24;
>> ./gui/wm/ws.c:326:     wsConvFunc=rgb32to16;
>> ./gui/wm/ws.c:330:     wsConvFunc=rgb32tobgr16;
>> ./gui/wm/ws.c:334:     wsConvFunc=rgb32to15;
>> ./gui/wm/ws.c:338:     wsConvFunc=rgb32tobgr15;
>> ./gui/win32/skinload.c:167:      rgb32tobgr32(bmp.Image, bmp.Image, bmp.ImageSize);
>> ./gui/win32/skinload.c:168:      if(skin->desktopbpp == 16) rgb32tobgr15(bmp.Image, bf->data, bmp.ImageSize);
>> ./gui/win32/skinload.c:169:      else if(skin->desktopbpp == 24) rgb32tobgr24(bmp.Image, bf->data, bmp.ImageSize);
>> ./libvo/mga_template.c:84:    interleaveBytes(image[1],image[2],dest,
>>
>> Comments, opinions, thoughts...?
>
> I don't think it's worth spending much time on this.  Just drop that
> feature from vo_mga and delete the GUI finally.

Patch attached with feature disabled in vo_mga and code changed in the
gui. I know the code in the GUI could use swscale directly to convert
to big- or little-endian rgb, but I certainly don't care enough to
speed that up.
I'll leave the battle of dropping or not the gui up to you guys =)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.diff
Type: text/x-patch
Size: 6984 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100904/4c440b00/attachment.bin>