[MPlayer-dev-eng] [RFC] EDL seeking and timing

[Reynaldo H. Verdejo Pinochet]

Hi

Diego Biurrun wrote:
> On Fri, Sep 03, 2010 at 04:00:43PM -0400, Vlad Seryakov wrote:
>> Attached is the new patch, i ran the doc text via native speaking
>> person, so at least it is not complete nonsense but style of course
>> can always be challenged.
>>
>> --- DOCS/man/en/mplayer.1	(revision 32040)
>> +++ DOCS/man/en/mplayer.1	(working copy)
>> @@ -890,6 +890,22 @@
>>  .
>>  .TP
>> +.B \-edl-start-pts
>> +Adjust positions in EDL records according to file's start time.
> 
> What file?

Done, hope its clearer now.

> 
>> +Some formats, especially MPEG TS usually start with non-zero PTS
>> +values and when producing EDL file with \-edlout option, EDL records
> 
> Break this sentence in two.

Can't do. Please do it yourself. Your English is far better than mine.

> 
>> +contain absolute values that are correct only to this particular file.
> 
> for this

Done.

> 
>> +If re-encoded into different format, this EDL file no longer applies.
> 
> a different

Done.

> 
>> --- mplayer.c	(revision 32040)
>> +++ mplayer.c	(working copy)
>> @@ -3639,6 +3639,16 @@
>> +  // Adjust EDL positions with start_pts
>> +  if (edl_start_pts && start_pts) {
>> +      edl_record_ptr edl = edl_records;
>> +      while (edl) {
>> +          edl->start_sec += start_pts;
>> +          edl->stop_sec += start_pts;
> 
> Align the +=.
> 

Done.

--
Reynaldo