[MPlayer-dev-eng] [PATCH] Capture feature

[Pásztor Szilárd]

Reimar Döffinger:
> I don't really like that design.

That's no problem because there isn't really a design.

> Can't you put the FILE * in the stream struct?
> You'll then dump which ever stream you set the FILE * on (and
> could even dump several into the same file in case this ever makes sense).

I could, but then come some problems with handling the file name.
Dumping multiple streams into one file doesn't make sense, and
dumping multiple streams in parallel into different files needs
different file names.

> A very minor thing (that I don't really know if it is solvable):
> AFAICS you dump on filling the buffer.
> This means with heavy seeking it'll dump more data than what
> is actually read.
> I thought about instead dumping the previous buffer before it is
> overwritten because then the pos will indicate how much was read
> from it.

Could be done but, in reality, seeking pretty much breaks dumping.
It doesn't make sense to seek back and forth while dumping. Even
though this capture thing could be used as a poor man's video
editing tool for MPEG streams, mainly it is useful for digital TV.

(Anyway, is there something against setting the NON_SEEKABLE flag
for DVB streams?)