[MPlayer-dev-eng] [PATCH] Capture feature

[Reimar Döffinger]

On Wed, Sep 01, 2010 at 08:41:58PM +0200, Pásztor Szilárd wrote:
> Nevertheless, I'd like to have your opinions on the concept,
> and so on, if you can take the time for a short look.

That just won't work like this. You can't assume there will
only be one stream.
-audiofile will use an extra stream, ASS files will be loaded
through the stream interface, BluRay reading will use multiple
streams for different things.
In any of these cases this implementation would dump a random
mixture of these streams.
I also think it is a bit too easy to enable by accident, the user
should have to do something (e.g. explicitly specify a filename)
to enable it.
Documentation should also mention that the output will be useless
for anything but MPEG-streams (which I guess basically means
DVD, BluRay or digital TV).
And if there's an error it would probably be good to print some
indication of it on the OSD.