[MPlayer-dev-eng] [PATCH 1/7] Unescape login/password before base64 encode

[Clément Bœsch]

On Sun, Oct 24, 2010 at 08:31:06PM +0200, Reimar Döffinger wrote:
> On Sun, Oct 24, 2010 at 08:10:00PM +0200, Clément Bœsch wrote:
> > On Mon, Oct 18, 2010 at 12:05:51PM +0200, Clément Bœsch wrote:
> > > I already sent it in a previous mail: it allows login/password to be
> > > unescaped before base64 encode so auth with special characters now
> > > works.
> > 
> > Still no news about this first patch; it should not require a lot of
> > skills to review this stuff, even if it's 8 patches. Can anyone do it, or
> > at least start with this one please? Those bugs are really annoying and
> > easy to fix…
> 
> It's not at all easy to figure out if they actually fix more or break more...
> This first patch for example I don't think anyone who has a %-sign in the
> password will like.
> Does e.g. Firefox really try to unescape the password?

The unescape is done because the URL is url-encoded in MPlayer (and so
login/password). '%' seems to work:

% ./mplayer 'http_proxy://login_x:a%b%c@localhost:8123/http://localhost:8000
[...]

% polipo daemonise=false 'authCredentials="login_x:a%b%c"'
Established listening socket on port 8123.

% nc -v -l localhost -p 8000
Connection from 127.0.0.1:32831
GET / HTTP/1.1
Host: localhost:8000
User-Agent: MPlayer UNKNOWN-4.5.1
Icy-MetaData: 1
Connection: keep-alive

-- 
Clément B.
Not sent from a jesusPhone.