[MPlayer-dev-eng] [PATCH] Capture feature

Giorgio mywing81 at gmail.com
Sat Oct 23 11:52:52 CEST 2010


> OK, I finally applied your patch, sorry this took so long and thank you
> for being patient and taking the time to go through all those revisions.

Hmm.. if I run "mplayer -capture dvb://RaiUno" and press the 'c' key,
capturing starts but I get the following message:

Capturing not enabled (forgot -capture parameter?)

I see there is a difference between the original patch and the one
that was applied, in particular:

Original:
+        if (capturing) {
+            if (capture_dump) {
+                if (!(mpctx->stream->capture_file =
fopen(stream_dump_name, "wb"))) {
+                    mp_msg(MSGT_GLOBAL, MSGL_ERR, "Error opening
capture file: %s\n", strerror(errno));
+                    ret = M_PROPERTY_ERROR;
+                }
+            } else {
+                mp_msg(MSGT_GLOBAL, MSGL_ERR, "Capturing not enabled
(forgot -capture parameter?)\n");
+                ret = M_PROPERTY_ERROR;
+            }
+        } else {
+            fclose(mpctx->stream->capture_file);
+            mpctx->stream->capture_file = NULL;
+        }


Applied:
+        if (capturing) {
+            if (capture_dump && !(mpctx->stream->capture_file =
fopen(stream_dump_name, "wb"))) {
+                mp_msg(MSGT_GLOBAL, MSGL_ERR,
+                       "Error opening capture file: %s\n", strerror(errno));
+                ret = M_PROPERTY_ERROR;
+            } else {
+                mp_msg(MSGT_GLOBAL, MSGL_ERR,
+                       "Capturing not enabled (forgot -capture parameter?)\n");
+                ret = M_PROPERTY_ERROR;
+            }
+        } else {
+            fclose(mpctx->stream->capture_file);
+            mpctx->stream->capture_file = NULL;
+        }

The second "if" was changed and introduced this problem. The original
patch works fine.
Thanks.

Giorgio Vazzana


More information about the MPlayer-dev-eng mailing list