[MPlayer-dev-eng] [PATCH] Two small subtitles improvments

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Oct 17 18:00:27 CEST 2010


On Sat, Oct 16, 2010 at 01:20:37PM +0200, Clément Bœsch wrote:
> On Wed, Oct 06, 2010 at 10:13:42PM +0200, Reimar Döffinger wrote:
> > > Index: subreader.c
> > > ===================================================================
> > > --- subreader.c	(revision 32415)
> > > +++ subreader.c	(working copy)
> > > @@ -1130,13 +1129,8 @@
> > >  		{*uses_time=1;return SUB_VPLAYER;}
> > >  	if (sscanf (line, "%d:%d:%d ",     &i, &i, &i )==3)
> > >  		{*uses_time=1;return SUB_VPLAYER;}
> > > -	//TODO: just checking if first line of sub starts with "<" is WAY
> > > -	// too weak test for RT
> > > -	// Please someone who knows the format of RT... FIX IT!!!
> > > -	// It may conflict with other sub formats in the future (actually it doesn't)
> > > -	if ( *line == '<' )
> > > +	if (!strncasecmp(line, "<window", 7))
> > >  		{*uses_time=1;return SUB_RT;}
> > > -
> > >  	if (!memcmp(line, "Dialogue: Marked", 16))
> > >  		{*uses_time=1; return SUB_SSA;}
> > 
> > Seems fine.
> 
> Ping?

Finally applied.


More information about the MPlayer-dev-eng mailing list