[MPlayer-dev-eng] stereo3d filter

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Oct 17 15:35:25 CEST 2010


On Sun, Oct 17, 2010 at 02:12:13PM +0200, Endre Kollár wrote:
> 2010/10/17 Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> 
> > > Im not sure that i understand it. The "Re: [MPlayer-dev-eng] [PATCH] view
> > > stereoscopic videos" should be the subject of the letter. That was your
> > ask?
> > >
> > > I do not understand what the debate is really about the coding style.
> > Kernel
> > > source, simply run the "checkpatch.pl" script, and tells you where the
> > style
> > > of errors is. Are there big differeces between this style and the kernel
> > > style?
> >
> > Forget the cosmetics debate.
> > I was thinking more of e.g. these comments:
> > http://permalink.gmane.org/gmane.comp.video.mplayer.devel/54804
> >
> 
> Uh, I was looking for the final version, but I could not find their way
> around.
> http://article.gmane.org/gmane.comp.video.mplayer.devel/54802
> 
> It looks much nicer than what I used.
> Do you suggest to make a diff of my changes? Merge a version? Which?

Ideally? We'd get a version of above patch with only the requested changes
(so we don't have to restart review from scratch) and then you'd send your
patches on top of that after it is applied.


More information about the MPlayer-dev-eng mailing list