[MPlayer-dev-eng] [PATCH] -force-key-frames option

[Nicolas George]

Le sextidi 26 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> If even the linux man page tells you not to rely on it I'd say
> it must be very common.
> Note that not even Windows (using msvcrt) claims to comply to either
> of the standards you quote.

All right. Attached, a new version that uses ">= 3" instead of "== 3", which
should work in both cases.

> For the current use cause even that is overkill.
> For that you just need to check that the following char is either 0 or ','.
> You do not need to return a length or change the function in any other way,
> and just need to add a strchr - in the current usage (if you want to fix them)
> to check that there is no ',', in the new usages to advance to the next time.

I am not sure what your point really is.

The version in my current proposal:

- returns the length, or 0 for error, instead of the ugly magical -1E100;

- if the third argument is 0, it returns an error if there is anything after
  the timestamp;

- if the third argument is ',', it returns an error if there is anything
  after the timestamp except a comma.

Is it ok?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-forcekeyframes-20101017-1427-01-parser.diff
Type: text/x-diff
Size: 2254 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101017/e9abb475/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101017/e9abb475/attachment.pgp>