[MPlayer-dev-eng] [PATCH]printf format string used everywhere

[Reimar Döffinger]

On Wed, Oct 13, 2010 at 08:44:12PM +0200, Frédéric Marchal wrote:
> On Saturday 09 October 2010 14:10:38 Reimar Döffinger wrote:
> > On Fri, Oct 08, 2010 at 09:20:49PM +0200, Frédéric Marchal wrote:
> > > On Thursday 07 October 2010 21:09:48 Reimar Döffinger wrote:
> > > > On Wed, Sep 15, 2010 at 01:38:28PM +0200, Frédéric Marchal wrote:
> > > > > Index: stream/librtsp/rtsp_rtp.c
> > > > > -  snprintf (dest, len, parse1 + strlen (RTSP_SETUP_DESTINATION));
> > > > > +  snprintf (dest, len, "%s", parse1 + strlen
> > > > > (RTSP_SETUP_DESTINATION));
> > > > 
> > > > av_strlcpy ?
> > > 
> > > There are four other instances of snprintf("%s") with three of them that
> > > are probable candidates for the same change. Should I try to replace
> > > those too ?
> > 
> > Would make sense IMO.
> 
> Let's try this patch then. Excuse me for the poor quality of the previous patch. I hope
> this one is better...
> 
> The change in gui/mplayer/gui_common.c breaks the symmetry with the other cases
> that are using snprintf to format their numeric argument. You may want not to apply
> it.

Applied that way, thanks. You should attach patches though, your mailer added
a line-break where it should not.

> Frederic

Gave up on spelling your name "properly" yourself? :-)