[MPlayer-dev-eng] [PATCH] SMPlayer's audio equalizer slave command patch

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Oct 11 22:21:36 CEST 2010


On Mon, Oct 11, 2010 at 09:56:11PM +0200, Adrian Stutz wrote:
> On Sun, Jul 11, 2010 at 23:38, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > Yes, it is annoyingly specific.
> > A command that selects an audio filter either by name or index and
> > then sends it the argument as AF_CONTROL_COMMAND_LINE would
> > be far, far, nicer.
> 
> Excuse me if I'm just being blind but how is the patch not doing exactly that?
> 
> It gets the audio filter by name:
> > af_instance_t* m1=af_get(sh_audio->afilter, "equalizer");

No, it select the "equalizer" filter, not _a_ filter (i.e. the name
should be an argument to the command).
And being able to do the same by index instead would be useful as well
(in case there are multiple filters of the same name).


More information about the MPlayer-dev-eng mailing list