[MPlayer-dev-eng] [PATCH] Two small subtitles improvments

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Oct 6 18:49:49 CEST 2010


On Wed, Oct 06, 2010 at 06:40:33PM +0200, Clément Bœsch wrote:
> On Thu, Sep 30, 2010 at 11:12:50AM +0200, Clément Bœsch wrote:
> > On Thu, Sep 30, 2010 at 08:11:18AM +0200, Reimar Döffinger wrote:
> > > On Thu, Sep 30, 2010 at 12:33:38AM +0200, Clément Bœsch wrote:
> > > > [...]
> > > 
> > > Using stristr instead of just checking the start might
> > > actually increase the risk of conflict, particularly considering future
> > > HTML- or XML-based formats...
> > 
> > Ok, fixed.
> > 
> > > Also removing the empty line does not really belong here
> > 
> > Well, according to the context, it was relative to the comments I removed:
> > a separator was needed to know to what the comments were talking about.
> > 
> > > and don't
> > > add a space after the function name for new code.
> > 
> > Ok.
> > 
> 
> Ping?

Sorry, I never received that mail you are quoting there.
Could you send the patch again?


More information about the MPlayer-dev-eng mailing list