[MPlayer-dev-eng] [PATCH] Subtitle display is based on audio - should be video

[gillou.ray at free.fr]

On Sat, 2 Oct 2010 17:15:21 +0200
Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:

> > Moreover, my proposed patch makes the ds_get_packet_sub()
> > parameters to actually do what their documentation says.
> 
> Not initializing the output parameters is not such a good idea.

Oops :)

> I applied a different method.

Thank you for fixing the overlaps bug.

> > You can easily produce the bug giving a -delay option to a subtitled
> > movie. I tested various combinations of demuxers and files. The bug
> > happens when :
> > - ass rendering is disabled
> > - subtitles are packed in a container (not red from a text file)
> > - with both ffpmeg and mplayer mkv demuxer, and ffmpeg ogg demuxer
> > - with muxed ASS or SRT 
> 
> I have to admit that this inconsistency is not so good though.

It's quite confusing indeed, that's why I actually got it all wrong.
What I was thinking to be the correct way is a bug, and the "regular
way" (i.e. everything that doesn't match the above list) is buggy. Even
the good old -sub file.srt is video synced. Gotta file this on the
bugtracker.

> > Another thing: with certain combination of stream types and demuxers
> > (e.g. with mplayer mkv demuxer and ASS muxed subs), the resulting
> > bug is a bit different. It displays each subtitle from their audio
> > timestamp start to their video timestamp end, resulting in
> > overlaps. E.g. if a subtitle is from 00:03s to 00:06s, with -delay
> > 2 it is displayed from 00:01s to 00:06s. The patch solves this
> > problem too.
> 
> Your patch changes nothing concerning audio- vs. video-based timing.
> With the buggy ds_get_packet_sub function, the subtitle would be
> displayed as soon as it is demuxed instead of in sync.

Got it. Thanks for your time :)

		-- gillux
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101002/4262436e/attachment.pgp>