[MPlayer-dev-eng] [PATCH] Subtitles directories

[Clément Bœsch]

On Tue, Nov 23, 2010 at 08:07:25AM +0100, Reimar Döffinger wrote:
> On Tue, Nov 23, 2010 at 12:50:45AM +0100, Clément Bœsch wrote:
> > Oh. This is bad. How do you want me to handle that? Of course I personally
> > consider the factorization also being a fix for the MEncoder code, but
> > something tell me you won't agree with that :-(
> 
> I am ok with considering a fix, I am just not convinced it is fixing it
> the right way round. But it probably is more flexible this way.
> 
> > By the way, is the rest of this first patch clear enough now?
> 
> I didn't look that closely yet. I still think it is too much code,
> but that is just a gut feeling and may be wrong of course.

Sorry I couldn't simplify it more. Still not good to commit?

Also, I noticed the VOB-Sub loading is totally different from the default
one. I'd like to work on it to make it benefit from other subtitles
options (like sub-fuzziness, sub-directories too, etc); I'd like to get
rid of the hackish loading in mplayer.c. I really can't integrate the
subdirs option for vobsub in the current state without huge changes (and I
don't think you want that, neither I do since it will delay the patch
again).

-- 
Clément B.
Not sent from a jesusPhone.