[MPlayer-dev-eng] [PATCH] Expose the VBV options of Xvid >= 1.1.0 in -xvidencopts

Lasse Collin lasse.collin at tukaani.org
Sun Nov 28 18:57:49 CET 2010


On 2010-11-27 Ivan Kalvachev wrote:
> On 11/22/10, Ivan Kalvachev <ikalvachev at gmail.com> wrote:
> > On 11/21/10, Lasse Collin <lasse.collin at tukaani.org> wrote:
> >> On 2010-11-10 Lasse Collin wrote:
> >>> The VBV options allow restricting the peak bitrate for hardware
> >>> player compatibility. Earlier the VBV options were only
> >>> indirectly available via the profiles.
> >>> 
> >>> When using profiles, vbv_peakrate is no longer incorrectly
> >>> multiplied by three (the incorrect code was copied from Xvid
> >>> itself). It doesn't matter in practice at all though because
> >>> Xvid uses vbv_peakrate only for some debug checks. It has no
> >>> effect on the encoded output.
> >> 
> >> *bump*
> > 
> > The C part looks OK.
> > If nobody object I'll test it and would commit the whole patch (man
> > page including) this weekend.
> > 
> > BTW, there is no need to wait for me ;)
> 
> Committed.

Thank you.

> Next time please send the patch as attachment...

Sorry about the wrong format. It would be nice if 
<http://www.mplayerhq.hu/design7/mailing_lists.html> would say something 
like "Patches should be sent as attachments, not inline." because 
different projects have different preferences.

-- 
Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode


More information about the MPlayer-dev-eng mailing list