[MPlayer-dev-eng] [PATCH] Add support for login/password in http_proxy env variable

[Reimar Döffinger]

On Wed, Nov 24, 2010 at 08:34:40PM +0100, Clément Bœsch wrote:
> +    if (proxy->username && proxy->password)
> +        return snprintf(dst, dst_size, "http_proxy://%s:%s@%s:%d/%s",
> +                        proxy->username, proxy->password, proxy->hostname,
> +                        proxy->port, host_url);
> +    else
> +        return snprintf(dst, dst_size, "http_proxy://%s:%d/%s",
> +                        proxy->hostname, proxy->port, host_url);

I think some other code supported also setting only username.
Also is port certain to be valid (!= 0) here?